Merged
Conversation
- concatentation of TF-MInDi anndata objects while preserving adata.var and adata.uns["unique_examples"]
- Has option `idx_match` so user can specify whether index columns in adata.obs ("example_oh_idx", "example_contrib_idx", "example_idx") refer to the same data across adatas or not
Related to issue:
Better user experience for concatenating multiple TF-MInDi objects.
Fixes #22
LukasMahieu
reviewed
Nov 3, 2025
Collaborator
LukasMahieu
left a comment
LukasMahieu
left a comment
There was a problem hiding this comment.
Looks good, but make sure these changes will be documented in the readthedocs by adding the function names to the appropriate markdown files in the docs/ folder (and building the docs locally to see if it works). If this new function doesn't fall under any existing category, it should get a new markdown file (maybe it fits under tfmindi.pp?)
Collaborator
Author
|
Ah yes, good point. |
Collaborator
|
LGTM! Can be merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New TF-MInDi Anndata concatenation features
idx_matchso user can specify whether index columns in adata.obs ("example_oh_idx", "example_contrib_idx", "example_idx") refer to the same data across adatas or notI cherry-picked these commits from PR #16, given that that PR seems to require some more work.
Related to issue:
Better user experience for concatenating multiple TF-MInDi objects. Fixes #22